fix(DateTimeRange): should close popup after click confirm button #5668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request fixes an issue where the DateTimeRange popup was not closing after clicking the confirm button. It also includes version updates and removes the Sequence diagram for closing DateTimeRange popup after confirmsequenceDiagram
participant User
participant DateTimeRange Component
participant JavaScript
User->>DateTimeRange Component: Click Confirm Button
DateTimeRange Component->>DateTimeRange Component: EditContext.NotifyFieldChanged(FieldIdentifier.Value)
DateTimeRange Component->>JavaScript: InvokeVoidAsync("hide", Id)
JavaScript-->>DateTimeRange Component: Await
DateTimeRange Component-->>User: Popup closes
Updated class diagram for DateTimeRange componentclassDiagram
class DateTimeRange {
-string Id
-EditContext EditContext
+Task ClickConfirmButton()
}
DateTimeRange : +InvokeVoidAsync("hide", Id)
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you're removing the
data-bb-dismissattribute from the DateTimeRange and DateTimePicker components, which might have unintended consequences; can you confirm this is the desired behavior?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5668 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 654 654
Lines 29681 29683 +2
Branches 4216 4216
=========================================
+ Hits 29681 29683 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5667
Summary By Copilot
This pull request includes several updates to the
BootstrapBlazorproject, focusing on version updates and improvements to theDateTimePickerandDateTimeRangecomponents. The most important changes are listed below:Version Update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated the project version from9.5.0-beta07to9.5.0-beta08.Component Enhancements:
src/BootstrapBlazor/Components/DateTimePicker/DateTimePicker.razor: Removed thedata-bb-dismissattribute from the maindivelement to simplify the component structure.src/BootstrapBlazor/Components/DateTimeRange/DateTimeRange.razor: Removed thedata-bb-dismissattribute from the maindivelement and adjusted the formatting ofDatePickerBodyproperties for better readability. [1] [2]Bug Fix:
src/BootstrapBlazor/Components/DateTimeRange/DateTimeRange.razor.cs: Added a call toInvokeVoidAsync("hide", Id)in theClickConfirmButtonmethod to ensure the date-time range picker is properly hidden after confirming a selection.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fixes a bug where the DateTimeRange popup does not close after clicking the confirm button. Also updates the project version and simplifies the component structure of DateTimePicker and DateTimeRange by removing the data-bb-dismiss attribute.
Bug Fixes:
Enhancements: